[Dashboard] fix Export CSV doesnt work #198547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
added
release_note:fix
backport:version
|
I really wonder why CI didnt complain here 🤔 |
💚 Build Succeeded
Metrics [docs]
|
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
Closes elastic#198517 elastic#193644 refactored Dashboard services. Part of this refactor moved `fieldFormats` from `data.fieldFormats` to getting `fieldFormats` directly from the fieldFormats plugin. That is because `data.fieldFormats` is marked as deprecated. The problem is that the fieldFormats plugin was not defined under `requiredPlugins` and thus was undefined at runtime. ### Test instructions 1) install web logs sample data 2) open web logs sample data dashboard 3) hover over "[Logs] Response Codes Over Time + Annotations" panel and select "three dots" icon. Then select "Download CSV". Verify there are no errors in web browser console and CSV is downloaded. (cherry picked from commit 0cd2d92)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
Closes elastic#198517 elastic#193644 refactored Dashboard services. Part of this refactor moved `fieldFormats` from `data.fieldFormats` to getting `fieldFormats` directly from the fieldFormats plugin. That is because `data.fieldFormats` is marked as deprecated. The problem is that the fieldFormats plugin was not defined under `requiredPlugins` and thus was undefined at runtime. ### Test instructions 1) install web logs sample data 2) open web logs sample data dashboard 3) hover over "[Logs] Response Codes Over Time + Annotations" panel and select "three dots" icon. Then select "Download CSV". Verify there are no errors in web browser console and CSV is downloaded. (cherry picked from commit 0cd2d92)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[Dashboard] fix Export CSV doesnt work (#198547)](#198547) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:37:51Z","message":"[Dashboard] fix Export CSV doesnt work (#198547)\n\nCloses https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644 refactored Dashboard\r\nservices. Part of this refactor moved `fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats` directly from the\r\nfieldFormats plugin. That is because `data.fieldFormats` is marked as\r\ndeprecated. The problem is that the fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover over \"[Logs] Response Codes Over Time + Annotations\" panel and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify there are\r\nno errors in web browser console and CSV is downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[Dashboard] fix Export CSV doesnt work","number":198547,"url":"https://github.com/elastic/kibana/pull/198547","mergeCommit":{"message":"[Dashboard] fix Export CSV doesnt work (#198547)\n\nCloses https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644 refactored Dashboard\r\nservices. Part of this refactor moved `fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats` directly from the\r\nfieldFormats plugin. That is because `data.fieldFormats` is marked as\r\ndeprecated. The problem is that the fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover over \"[Logs] Response Codes Over Time + Annotations\" panel and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify there are\r\nno errors in web browser console and CSV is downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198547","number":198547,"mergeCommit":{"message":"[Dashboard] fix Export CSV doesnt work (#198547)\n\nCloses https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644 refactored Dashboard\r\nservices. Part of this refactor moved `fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats` directly from the\r\nfieldFormats plugin. That is because `data.fieldFormats` is marked as\r\ndeprecated. The problem is that the fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover over \"[Logs] Response Codes Over Time + Annotations\" panel and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify there are\r\nno errors in web browser console and CSV is downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Dashboard] fix Export CSV doesnt work (#198547)](#198547) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:37:51Z","message":"[Dashboard] fix Export CSV doesnt work (#198547)\n\nCloses https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644 refactored Dashboard\r\nservices. Part of this refactor moved `fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats` directly from the\r\nfieldFormats plugin. That is because `data.fieldFormats` is marked as\r\ndeprecated. The problem is that the fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover over \"[Logs] Response Codes Over Time + Annotations\" panel and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify there are\r\nno errors in web browser console and CSV is downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.17.0","v8.16.1"],"title":"[Dashboard] fix Export CSV doesnt work","number":198547,"url":"https://github.com/elastic/kibana/pull/198547","mergeCommit":{"message":"[Dashboard] fix Export CSV doesnt work (#198547)\n\nCloses https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644 refactored Dashboard\r\nservices. Part of this refactor moved `fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats` directly from the\r\nfieldFormats plugin. That is because `data.fieldFormats` is marked as\r\ndeprecated. The problem is that the fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover over \"[Logs] Response Codes Over Time + Annotations\" panel and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify there are\r\nno errors in web browser console and CSV is downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198547","number":198547,"mergeCommit":{"message":"[Dashboard] fix Export CSV doesnt work (#198547)\n\nCloses https://github.com/elastic/kibana/issues/198517\r\n\r\nhttps://github.com/elastic/kibana/pull/193644 refactored Dashboard\r\nservices. Part of this refactor moved `fieldFormats` from\r\n`data.fieldFormats` to getting `fieldFormats` directly from the\r\nfieldFormats plugin. That is because `data.fieldFormats` is marked as\r\ndeprecated. The problem is that the fieldFormats plugin was not defined\r\nunder `requiredPlugins` and thus was undefined at runtime.\r\n\r\n### Test instructions\r\n1) install web logs sample data\r\n2) open web logs sample data dashboard\r\n3) hover over \"[Logs] Response Codes Over Time + Annotations\" panel and\r\nselect \"three dots\" icon. Then select \"Download CSV\". Verify there are\r\nno errors in web browser console and CSV is downloaded.","sha":"0cd2d924dea85ec02d65bcf967b28dac96714ed3"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
Closes elastic#198517 elastic#193644 refactored Dashboard services. Part of this refactor moved `fieldFormats` from `data.fieldFormats` to getting `fieldFormats` directly from the fieldFormats plugin. That is because `data.fieldFormats` is marked as deprecated. The problem is that the fieldFormats plugin was not defined under `requiredPlugins` and thus was undefined at runtime. ### Test instructions 1) install web logs sample data 2) open web logs sample data dashboard 3) hover over "[Logs] Response Codes Over Time + Annotations" panel and select "three dots" icon. Then select "Download CSV". Verify there are no errors in web browser console and CSV is downloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198517
#193644 refactored Dashboard services. Part of this refactor moved
fieldFormatsfromdata.fieldFormatsto gettingfieldFormatsdirectly from the fieldFormats plugin. That is becausedata.fieldFormatsis marked as deprecated. The problem is that the fieldFormats plugin was not defined underrequiredPluginsand thus was undefined at runtime.Test instructions